Fix ar1_turningpts build: drop figsize from az.plot_trace#930
Open
jstac wants to merge 1 commit into
Open
Conversation
arviz 1.x dropped the figsize kwarg on plot_trace, which raises ValueError and fails notebook execution once the build cache is invalidated. Remove figsize from the az.plot_trace call (arviz uses its default size). Verified against arviz 1.2.0 that plot_trace(idata) and trace.posterior.rho access both still work. Closes #929 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📖 Netlify Preview Ready!Preview URL: https://pr-930--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #929.
ar1_turningpts.mdcallsaz.plot_trace(trace, figsize=(17, 6)). Under arviz 1.x (thearviz_plotsbackend)plot_traceno longer acceptsfigsizeand raisesValueError, failing notebook execution. It is latent onmainonly because the execution cache predates arviz 1.x.Fix: drop the
figsizekwarg (arviz uses its default size, also more consistent with the figure styleguide).Verified against arviz 1.2.0 that
az.plot_trace(idata)withoutfigsize, andtrace.posterior.rho.valuesattribute access, both still work — thefigsizekwarg was the only problem. A repo-wide grep confirms this is the last remaining arviz plotting call passingfigsize(the same fix inar1_bayes.mdis in #927).🤖 Generated with Claude Code