Skip to content

feat(qov-1986) Handle external secrets#660

Open
mzottola wants to merge 2 commits into
mainfrom
qov-1986
Open

feat(qov-1986) Handle external secrets#660
mzottola wants to merge 2 commits into
mainfrom
qov-1986

Conversation

@mzottola

Copy link
Copy Markdown
Contributor

No description provided.

@mzottola mzottola changed the title feat(qov-1986) Handle service external secrets feat(qov-1986) Handle external secrets Jun 11, 2026
@mzottola mzottola requested a review from Copilot June 11, 2026 08:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds CLI support for managing “external secrets” (secrets referenced from an external secret manager) across multiple Qovery resource types, and updates the Qovery Go client dependency to a version that supports the needed API fields.

Changes:

  • Add utils helpers to create/update external-secret variables (secret-manager access ID, reference, optional mount path) and extend variable scoping to Terraform.
  • Add external-secret subcommands (create/update/delete) for application, container, cronjob, lifecycle job, helm, terraform, and environment.
  • Bump github.com/qovery/qovery-client-go to a newer revision.

Reviewed changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
utils/env_var.go Adds external-secret create/update helpers and Terraform scope support.
go.mod Updates qovery-client-go dependency version.
go.sum Updates dependency checksums for qovery-client-go.
cmd/application_external_secret.go Adds application external-secret command group.
cmd/application_external_secret_create.go Adds create command for application external secrets.
cmd/application_external_secret_update.go Adds update command for application external secrets.
cmd/application_external_secret_delete.go Adds delete command for application external secrets.
cmd/container_external_secret.go Adds container external-secret command group.
cmd/container_external_secret_create.go Adds create command for container external secrets.
cmd/container_external_secret_update.go Adds update command for container external secrets.
cmd/container_external_secret_delete.go Adds delete command for container external secrets.
cmd/cronjob_external_secret.go Adds cronjob external-secret command group.
cmd/cronjob_external_secret_create.go Adds create command for cronjob external secrets.
cmd/cronjob_external_secret_update.go Adds update command for cronjob external secrets.
cmd/cronjob_external_secret_delete.go Adds delete command for cronjob external secrets.
cmd/lifecycle_external_secret.go Adds lifecycle external-secret command group.
cmd/lifecycle_external_secret_create.go Adds create command for lifecycle external secrets.
cmd/lifecycle_external_secret_update.go Adds update command for lifecycle external secrets.
cmd/lifecycle_external_secret_delete.go Adds delete command for lifecycle external secrets.
cmd/helm_external_secret.go Adds helm external-secret command group.
cmd/helm_external_secret_create.go Adds create command for helm external secrets.
cmd/helm_external_secret_update.go Adds update command for helm external secrets.
cmd/helm_external_secret_delete.go Adds delete command for helm external secrets.
cmd/terraform_external_secret.go Adds terraform external-secret command group.
cmd/terraform_external_secret_create.go Adds create command for terraform external secrets (incl. scope flag).
cmd/terraform_external_secret_update.go Adds update command for terraform external secrets.
cmd/terraform_external_secret_delete.go Adds delete command for terraform external secrets.
cmd/environment_external_secret.go Adds environment external-secret command group.
cmd/environment_external_secret_create.go Adds create command for environment external secrets.
cmd/environment_external_secret_update.go Adds update command for environment external secrets.
cmd/environment_external_secret_delete.go Adds delete command for environment external secrets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/environment_external_secret_create.go
Comment thread cmd/environment_external_secret_update.go
Comment thread cmd/environment_external_secret_delete.go
Comment thread cmd/application_external_secret.go
Comment thread cmd/container_external_secret.go
Comment thread cmd/cronjob_external_secret.go
Comment thread cmd/environment_external_secret.go
Comment thread cmd/helm_external_secret.go
Comment thread cmd/lifecycle_external_secret.go
Comment thread cmd/terraform_external_secret.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants