Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds CLI support for managing “external secrets” (secrets referenced from an external secret manager) across multiple Qovery resource types, and updates the Qovery Go client dependency to a version that supports the needed API fields.
Changes:
- Add utils helpers to create/update external-secret variables (secret-manager access ID, reference, optional mount path) and extend variable scoping to Terraform.
- Add
external-secretsubcommands (create/update/delete) for application, container, cronjob, lifecycle job, helm, terraform, and environment. - Bump
github.com/qovery/qovery-client-goto a newer revision.
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/env_var.go | Adds external-secret create/update helpers and Terraform scope support. |
| go.mod | Updates qovery-client-go dependency version. |
| go.sum | Updates dependency checksums for qovery-client-go. |
| cmd/application_external_secret.go | Adds application external-secret command group. |
| cmd/application_external_secret_create.go | Adds create command for application external secrets. |
| cmd/application_external_secret_update.go | Adds update command for application external secrets. |
| cmd/application_external_secret_delete.go | Adds delete command for application external secrets. |
| cmd/container_external_secret.go | Adds container external-secret command group. |
| cmd/container_external_secret_create.go | Adds create command for container external secrets. |
| cmd/container_external_secret_update.go | Adds update command for container external secrets. |
| cmd/container_external_secret_delete.go | Adds delete command for container external secrets. |
| cmd/cronjob_external_secret.go | Adds cronjob external-secret command group. |
| cmd/cronjob_external_secret_create.go | Adds create command for cronjob external secrets. |
| cmd/cronjob_external_secret_update.go | Adds update command for cronjob external secrets. |
| cmd/cronjob_external_secret_delete.go | Adds delete command for cronjob external secrets. |
| cmd/lifecycle_external_secret.go | Adds lifecycle external-secret command group. |
| cmd/lifecycle_external_secret_create.go | Adds create command for lifecycle external secrets. |
| cmd/lifecycle_external_secret_update.go | Adds update command for lifecycle external secrets. |
| cmd/lifecycle_external_secret_delete.go | Adds delete command for lifecycle external secrets. |
| cmd/helm_external_secret.go | Adds helm external-secret command group. |
| cmd/helm_external_secret_create.go | Adds create command for helm external secrets. |
| cmd/helm_external_secret_update.go | Adds update command for helm external secrets. |
| cmd/helm_external_secret_delete.go | Adds delete command for helm external secrets. |
| cmd/terraform_external_secret.go | Adds terraform external-secret command group. |
| cmd/terraform_external_secret_create.go | Adds create command for terraform external secrets (incl. scope flag). |
| cmd/terraform_external_secret_update.go | Adds update command for terraform external secrets. |
| cmd/terraform_external_secret_delete.go | Adds delete command for terraform external secrets. |
| cmd/environment_external_secret.go | Adds environment external-secret command group. |
| cmd/environment_external_secret_create.go | Adds create command for environment external secrets. |
| cmd/environment_external_secret_update.go | Adds update command for environment external secrets. |
| cmd/environment_external_secret_delete.go | Adds delete command for environment external secrets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.