TrustRegion: remove direct manipulation of sys.stdout / sys.__stdout__#3902
Merged
mrmundt merged 2 commits intoPyomo:mainfrom Apr 3, 2026
Merged
TrustRegion: remove direct manipulation of sys.stdout / sys.__stdout__#3902mrmundt merged 2 commits intoPyomo:mainfrom
sys.stdout / sys.__stdout__#3902mrmundt merged 2 commits intoPyomo:mainfrom
Conversation
mrmundt
approved these changes
Apr 3, 2026
blnicho
approved these changes
Apr 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3902 +/- ##
=======================================
Coverage 89.92% 89.93%
=======================================
Files 902 902
Lines 106393 106393
=======================================
+ Hits 95679 95681 +2
+ Misses 10714 10712 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
The trustregion tests directly manipulate
sys.stdout-- and in particular -- restore it to thesys.__stdout__. This can foul up some testing / redirection logic, particularly if the test fails (raises an exception) before restoring the state. This PR updates the trustregion tests to usecapture_output()instead of directly manipulatingsys.stdout.Changes proposed in this PR:
caputure_output()context manager instead of directly manipulatingsys.stdoutLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: