Skip to content

refactor: unify as_dataarray; split broadcasting from coords validation #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FBumann wants to merge 5 commits into
base: fix/mask-coords-broadcast
Choose a base branch
from
Open

refactor: unify as_dataarray; split broadcasting from coords validation #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
461c2b6
refactor: unify as_dataarray; split broadcasting from coords validation
FBumann May 24, 2026
fdff779
feat: dims= names unnamed coords; doctest the add_variables contract
FBumann May 25, 2026
a58ef68
feat: add align_to_coords with semantic validation error messages
FBumann May 25, 2026
351ae40
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 25, 2026
9fa18ef
refactor(model): simplify mask align; preserve TypeError in align_to_…
FBumann May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ Most users should keep calling ``model.solve(...)``. If you want more control, y

**Internal**

* ``linopy.common.as_dataarray`` is now the single broadcasting primitive;
strict subset-dim / coord-value checks live in
``assert_compatible_with_coords`` (via ``align_to_coords`` in
``add_variables`` / ``add_constraints``). Validation errors name the
argument (``lower bound``, ``upper bound``, ``mask``) and explain whether
dimensions or coordinate values disagree with ``coords``. When ``coords`` is
a mapping, extra keys beyond the positional ``dims`` are broadcast in rather
than dropped.
* Each ``Solver`` subclass now overrides at most three hooks: ``_build_direct`` (build the native model), ``_run_direct`` (run it), and ``_run_file`` (run the solver on an LP/MPS file). File-only solvers (CBC, GLPK, CPLEX, SCIP, Knitro, COPT, MindOpt) only override ``_run_file``.
* New ``ConstraintLabelIndex`` cached on ``Model.constraints`` (mirrors the existing ``Variables.label_index``); ``ConstraintBase`` gains ``active_labels()`` and a ``range`` property; ``CSRConstraint`` exposes ``coords``.
* ``linopy.common`` gains ``values_to_lookup_array``; the legacy pandas-based helpers ``series_to_lookup_array`` and ``lookup_vals`` are removed.
Expand Down
Loading