PDX-0: refactor(mcp): change org_describe workspace discovery paths#232
PDX-0: refactor(mcp): change org_describe workspace discovery paths#232Provar-tarunprashar wants to merge 6 commits into
Conversation
Release 1.6.0 — merge develop → main
RCA: org_describe resolved the Provar workspace via a sibling workspace-<name> dir; the layout needed updating so the project's parent directory is treated as the workspace root. Fix: workspaceCandidates now yields <parent>/, <parent>/Provar_Workspaces/workspace-<basename>/, and ~/Provar/workspace-<basename>/; discoverWorkspace requires a .metadata dir so candidate 1 falls through when the parent is not a workspace; removed the now-unused projectNameDashes helper and updated tests and docs.
|
Superseding this in favour of #233. #233 builds directly on your commit (preserved and credited there) but makes the workspace-discovery change additive instead of a replacement: it keeps the sibling We reproduced the customer's real layout and confirmed your root cause: PDX-515 fixed the SfObject cache parsing, but discovery still pointed at a non-existent sibling dir, so the parser never ran for the parent-layout. Your fix is the missing half — thank you for the RCA and the patch, @Provar-tarunprashar. Please follow along on #233. |
RCA: PDX-515 fixed SfObject cache parsing but the earlier release only probed the sibling workspace-<basename> directory, so parent-layout IDE workspaces were never discovered and the improved parser never ran for those users, and PR ProvarTesting#232 then dropped the sibling probe entirely which would regress sibling-layout users. Fix: workspaceCandidates now probes parent, then sibling workspace-<basename>, then Provar_Workspaces, then ~/Provar (each gated on a .metadata dir so no false-positive fault paths), preferring the parent IDE layout while keeping sibling workspaces discoverable; sync the in-tool description and docs/mcp.md to the four-candidate order and add a sibling-only back-compat regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 participants
RCA: org_describe resolved the Provar workspace via a sibling workspace- dir; the layout needed updating so the project's parent directory is treated as the workspace root.
Fix: workspaceCandidates now yields /, /Provar_Workspaces/workspace-/, and ~/Provar/workspace-/; discoverWorkspace requires a .metadata dir so candidate 1 falls through when the parent is not a workspace; removed the now-unused projectNameDashes helper and updated tests and docs.