Skip to content

Make get_norm_layer repr test tolerant of PyTorch bias= field #8880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjmjohnson wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −1
Open

Make get_norm_layer repr test tolerant of PyTorch bias= field #8880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/networks/layers/test_get_layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,19 @@

from __future__ import annotations

import re
import unittest

from parameterized import parameterized

from monai.networks.layers import get_act_layer, get_dropout_layer, get_norm_layer


def _strip_bias_field(text: str) -> str:
# PyTorch >= 2.13 adds an optional ``bias=`` field to norm-layer repr; drop it for version stability.
return re.sub(r",\s*bias=(?:True|False)", "", text)


TEST_CASE_NORM = [
[{"name": ("group", {"num_groups": 1})}, "GroupNorm(1, 1, eps=1e-05, affine=True)"],
[
Expand All @@ -41,7 +48,7 @@ class TestGetLayers(unittest.TestCase):
@parameterized.expand(TEST_CASE_NORM)
def test_norm_layer(self, input_param, expected):
layer = get_norm_layer(**input_param)
self.assertEqual(f"{layer}", expected)
self.assertEqual(_strip_bias_field(f"{layer}"), _strip_bias_field(expected))

@parameterized.expand(TEST_CASE_ACT)
def test_act_layer(self, input_param, expected):
Expand Down
Loading