Conversation
|
Is the explicit option super necessary or is this something we can auto-detect? Like the combination of the options |
|
It is not strictly necessary as you can put whatever values you want in the AFAIK there is no other way to define it, this must be statically defined and cannot be done at runtime. |
|
@jborean93 sorry, yes I am aware, this comment should have been on the actual implementation in PSES, sorry. |
|
I'm not sure if PSES could do it dynamically. Maybe a source generator to generate the record from the |
|
@jborean93 this PR is fine, my point was I was wondering if we could do away with the setting altogether in PSES and instead detect when the notify is needed based on the other launch options. If not that's totally fine, having it as a manual specification is not a problem, just thinking about user ergonomics. EDIT: And that can always come as a later optimization PR. |
Adds the new `notifyOnAttach` option for an attach request. This option will have PSES create a new event with the source identifier `PSES.Attached` that allows the attached script to wait for the attach event.
1c29be9 to
fe8dd4f
Compare
PR Summary
Adds the new
notifyOnAttachoption for an attach request. This option will have PSES create a new event with the source identifierPSES.Attachedthat allows the attached script to wait for the attach event.Should wait until PowerShell/PowerShellEditorServices#2250 is merged (or rejected).
PR Checklist
WIP:to the beginning of the title and remove the prefix when the PR is ready