Remove temporary base64 function used for coverage validation#1601
Open
SteveL-MSFT wants to merge 2 commits into
Open
Remove temporary base64 function used for coverage validation#1601SteveL-MSFT wants to merge 2 commits into
SteveL-MSFT wants to merge 2 commits into
Conversation
The base64_encode function and its tests were added solely to validate that the code coverage instrumentation was working. Now that coverage is confirmed working (97% on PR #1600), remove the temporary code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the temporary base64_encode helper, its unit tests, and its one call site from dsc/src/main.rs, now that Rust PR coverage instrumentation has been validated (per PR #1600).
Changes:
- Deleted the temporary
base64_encode()implementation fromdsc/src/main.rs. - Removed the call in
dsc_main()that existed only to exercise coverage. - Removed the associated unit test module that validated the helper.
Allow empty FileDetails array (e.g. when PR only deletes code) instead of failing with a mandatory parameter binding error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
😲 Code Coverage ReportChanged code coverage: 100% (100% coverage)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the temporary
base64_encodefunction and its unit tests fromdsc/src/main.rs. This code was added solely to validate that the code coverage instrumentation was working correctly (confirmed at 97% in PR #1600).Changes
base64_encode()functiontest_base64_encode_empty,test_base64_encode_basic,test_base64_encode_padding,test_base64_encode_coverage_string)dsc_main()