Add trace for output returned from resource#1447
Merged
SteveL-MSFT merged 1 commit intoPowerShell:mainfrom Mar 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds more detailed tracing around JSON verification for command-based DSC resources to help diagnose schema mismatches in resource output.
Changes:
- Emit a trace log when verifying JSON from a resource, including the raw JSON content.
- Update the localized
verifyJsonmessage to include the JSON payload.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/dsc-lib/src/dscresources/command_resource.rs | Changes JSON verification logging to trace and includes the JSON string in the message. |
| lib/dsc-lib/locales/en-us.toml | Updates the verifyJson localized string to include a %{json} placeholder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adityapatwardhan
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
While helping to investigate an issue with a new resource where
dscerrors that the schema didn't match, it required adding traces to the resource to emit the JSON it was returning. This change adds the raw output from a resource as atracein DSC to help diagnose JSON schema issues with output from resources.