Merged
Conversation
|
Will this be merged any time soon? |
Member
@nclavaud can you force push with signed commits? |
The codebase only uses Clock methods compatible with Symfony 8.0.
Remove the --verbose flag that does not exists anymore in PHPUnit 11.
nclavaud
force-pushed
the
feat/symfony_8
branch
from
6eb237f to
056c22c
Compare
Contributor
Author
@marandaneto done, thanks! |
Contributor
Author
|
Not sure how to fix the failing check Call Feature Flags Project Workflow, though 🤔 |
marandaneto
approved these changes
Mar 30, 2026
Member
not needed, this is internal and non blocking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR fixes #101 by updating the
symfony/clockdependency constraint to include version^8.0, as the codebase is already compatible with this version.Also, it removes the
--verboseflag in the test script to ensure compatibility with PHPUnit v11.Both changes are backward-compatible and improve the package's usability with newer versions of dependencies.
Thanks for reviewing!