feat(settings): label meep sounds as lorg and smol#2696
Open
pauldambra wants to merge 1 commit into
Open
Conversation
Generated-By: PostHog Code Task-Id: 2430b9a7-b698-48ba-95b6-d9c98328c2c2
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat(settings): label meep sounds as lor..." | Re-trigger Greptile |
|
personally i prefer just (smol). I've never seen lorg used before and i think having both labelled makes the (smol) less cute idk tho lol |
Member
Author
|
@frankh you're right to push back emdash i am coining lorg we're both here at the start of something huge options right now are
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The two meep notification sounds were labelled "Meep" and "Meep (smol)", which didn't make it clear that the first is the larger variant. Per the Slack thread, they should read "meep (lorg)" and "meep (smol)".
Changes
Renamed the larger meep option's label from "Meep" to "Meep (lorg)" in the sound picker, on both desktop (
GeneralSettings.tsx) and mobile (settings/index.tsx). The "Meep (smol)" label was already correct. Underlying sound values are unchanged.How did you test this?
Not tested beyond the edit — purely a display-label change.
Automatic notifications
Created with PostHog Code from a Slack thread