Skip to content

fix(sessions): scale context breakdown bar to the context window #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adboio wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −10
Draft

fix(sessions): scale context breakdown bar to the context window #2649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/ui/src/features/sessions/components/ContextBreakdownPopover.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,29 @@ describe("ContextBreakdownPopover", () => {
expect(screen.queryByText("Tools")).not.toBeInTheDocument();
expect(screen.queryByText("Rules")).not.toBeInTheDocument();
});

it("scales segments to the context window, not the used tokens", () => {
const { container } = render(
<Theme>
<ContextBreakdownPopover
usage={usageWith(
{
systemPrompt: 0,
tools: 0,
rules: 0,
skills: 0,
mcp: 0,
subagents: 0,
conversation: 50_000,
},
{ used: 50_000, size: 200_000, percentage: 25 },
)}
/>
</Theme>,
);
// 50K of a 200K window => the single segment fills a quarter of the bar,
// leaving the rest as empty track (remaining context).
const segment = container.querySelector('[style*="width: 25%"]');
expect(segment).not.toBeNull();
});
});
17 changes: 7 additions & 10 deletions packages/ui/src/features/sessions/components/ContextBreakdownPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function ContextBreakdownPopover({
</Text>

{breakdown ? (
<SegmentedBar breakdown={breakdown} total={used} fallback={fillColor} />
<SegmentedBar breakdown={breakdown} size={size} fallback={fillColor} />
) : (
<SinglePercentBar percentage={percentage} color={fillColor} />
)}
Expand Down Expand Up @@ -70,22 +70,19 @@ export function ContextBreakdownPopover({

function SegmentedBar({
breakdown,
total,
size,
fallback,
}: {
breakdown: NonNullable<ContextUsage["breakdown"]>;
total: number;
size: number;
fallback: string;
}) {
if (total <= 0) {
if (size <= 0) {
return <div className="h-1.5 w-full rounded-full bg-(--gray-4)" />;
}

const segmentSum = CONTEXT_CATEGORIES.reduce(
(acc, cat) => acc + Math.max(0, breakdown[cat.key]),
0,
);
const denominator = Math.max(total, segmentSum);
// Scale each segment to the full context window so the filled portion
// matches the "% full" figure and the empty track reads as remaining context.
return (
<div className="flex h-1.5 w-full overflow-hidden rounded-full bg-(--gray-4)">
{CONTEXT_CATEGORIES.map((cat) => {
Expand All @@ -95,7 +92,7 @@ function SegmentedBar({
<div
key={cat.key}
style={{
width: `${(value / denominator) * 100}%`,
width: `${(value / size) * 100}%`,
backgroundColor: cat.color || fallback,
}}
/>
Expand Down
Loading