Skip to content

feat(inbox): Show failed reports#1950

Merged
Twixes merged 7 commits intomainfrom
show-failed-reports
Apr 30, 2026
Merged

feat(inbox): Show failed reports#1950
Twixes merged 7 commits intomainfrom
show-failed-reports

Conversation

@Twixes
Copy link
Copy Markdown
Member

@Twixes Twixes commented Apr 30, 2026

Problem

Users have reported being surprised that reports mysteriously disappear from the inbox. In reality, some of these fail due to to process due to various reasons. We're looking into these reasons separately, but the important thing is not to surprise users.

Changes

Letting people see failed reports, with clear information about this:

Screenshot 2026-04-30 at 11 21 06@2x

@Twixes Twixes requested a review from a team April 30, 2026 09:25
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 30, 2026

Security Review

  • Reverse tabnapping (ReportDetailPane.tsx): the Discord <a> link uses target="_blank" without rel="noreferrer", allowing the opened tab to reference and navigate the opener via window.opener. Low severity in an Electron context but should still be fixed.

Comments Outside Diff (1)

  1. apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx, line 335-352 (link)

    P1 Misleading tooltip shown for failed reports

    report.status !== "ready" now includes "failed", so users viewing a failed report will see a tooltip saying "A full researched summary will replace it when the research agent completes its work" — but no agent will ever complete this report. The condition should exclude "failed" to avoid this false promise.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx
    Line: 335-352
    
    Comment:
    **Misleading tooltip shown for failed reports**
    
    `report.status !== "ready"` now includes `"failed"`, so users viewing a failed report will see a tooltip saying _"A full researched summary will replace it when the research agent completes its work"_ — but no agent will ever complete this report. The condition should exclude `"failed"` to avoid this false promise.
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 3 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 3
apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx:335-352
**Misleading tooltip shown for failed reports**

`report.status !== "ready"` now includes `"failed"`, so users viewing a failed report will see a tooltip saying _"A full researched summary will replace it when the research agent completes its work"_ — but no agent will ever complete this report. The condition should exclude `"failed"` to avoid this false promise.

### Issue 2 of 3
apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx:321-327
**Missing `rel="noreferrer"` on `target="_blank"` link**

Opening links with `target="_blank"` without `rel="noreferrer"` exposes the page to reverse tabnapping — the opened tab can navigate the opener via `window.opener`. Add `rel="noreferrer"` to close this.

```suggestion
                  <a
                    href={EXTERNAL_LINKS.discord}
                    target="_blank"
                    rel="noreferrer"
                    className="text-(--red-9) underline hover:text-(--red-11)"
                  >
```

### Issue 3 of 3
apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx:305
**`user-select-none` is not a valid Tailwind utility**

Tailwind's utility for `user-select: none` is `select-none`, not `user-select-none`. As written, the class has no effect and the text remains selectable.

```suggestion
              className="select-none rounded-sm border border-red-6 bg-red-2"
```

Reviews (1): Last reviewed commit: "feat(inbox): Show failed reports" | Re-trigger Greptile

Comment thread apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx Outdated
Twixes and others added 4 commits April 30, 2026 10:39
…DetailPane.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…DetailPane.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Twixes added 2 commits April 30, 2026 12:37
- Close failed-report Discord anchor with visible label text
- Use Record<string, never> instead of {} for ArtifactTransfer default
…k tag

- DEFAULT_STATUS_FILTER includes failed; update test expectations and beforeEach
- Restore <a> opening tag that was truncated in ReportDetailPane
@Twixes Twixes merged commit 4ef68d8 into main Apr 30, 2026
15 checks passed
@Twixes Twixes deleted the show-failed-reports branch April 30, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants