Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/main/services/cloud-task/service.test.ts:602-668
**Parameterise over all three guarded status codes**
`shouldFailWatcherForFetchStatus` guards against 401, 403, and 404, but both new tests only exercise 403. 401 (expired token) and 404 (run deleted) are distinct failure modes that are easy to miss if the function is ever changed.
The two tests also share exactly the same assertion shape and could be collapsed into an `it.each` table, matching the project's preference for parameterised tests.
Reviews (1): Last reviewed commit: "fix(cloud-agent): handle stream churn" | Re-trigger Greptile |
joshsny
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cloud task streams can churn when a live stream emits keepalives and then disconnects, or when the client loses access to task status/log endpoints.
keepalives were resetting the reconnect attempt counter, and 401/403/404 status or log responses were treated like generic transient failures as showni in slack thread logs
Changes