feat: allow user to use existing integration to connect in PC#1946
Open
feat: allow user to use existing integration to connect in PC#1946
Conversation
k11kirky
added
the
Create release
Graphite App
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 521-531
Comment:
**"Connect a different GitHub org" should be disabled while linking**
While `linkExistingMutation` is pending this button is still enabled, so a user who clicks "Reuse" and then immediately clicks "Connect a different GitHub org" can kick off a new OAuth flow while the link request is in flight. Consider disabling or hiding it when `linkExistingMutation.isPending`.
```suggestion
<Button
size="1"
variant="ghost"
color="gray"
loading={isConnecting}
disabled={linkExistingMutation.isPending}
onClick={() => void handleConnectGitHub()}
>
Connect a different GitHub org
<ArrowSquareOut size={12} />
</Button>
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 109
Comment:
**`alternativeSourceIntegrationId` is redundant**
`alternativeSourceIntegrationId` is just `alternativeSource?.id ?? null`. Since `alternativeSource` already exposes `id`, this extra variable violates OnceAndOnlyOnce — callers can use `alternativeSource?.id ?? null` directly or check `alternativeSource !== null` to gate the "Reuse" button.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat: allow user to use existing integra..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+521
to
+531
| <Button | ||
| size="1" | ||
| variant="ghost" | ||
| color="gray" | ||
| loading={isConnecting} | ||
| onClick={() => void handleConnectGitHub()} | ||
| > | ||
| Connect a different GitHub org | ||
| <ArrowSquareOut size={12} /> | ||
| </Button> | ||
| </Flex> |
There was a problem hiding this comment.
While linkExistingMutation is pending this button is still enabled, so a user who clicks "Reuse" and then immediately clicks "Connect a different GitHub org" can kick off a new OAuth flow while the link request is in flight. Consider disabling or hiding it when linkExistingMutation.isPending.
Suggested change
| <Button | |
| size="1" | |
| variant="ghost" | |
| color="gray" | |
| loading={isConnecting} | |
| onClick={() => void handleConnectGitHub()} | |
| > | |
| Connect a different GitHub org | |
| <ArrowSquareOut size={12} /> | |
| </Button> | |
| </Flex> | |
| <Button | |
| size="1" | |
| variant="ghost" | |
| color="gray" | |
| loading={isConnecting} | |
| disabled={linkExistingMutation.isPending} | |
| onClick={() => void handleConnectGitHub()} | |
| > | |
| Connect a different GitHub org | |
| <ArrowSquareOut size={12} /> | |
| </Button> |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 521-531
Comment:
**"Connect a different GitHub org" should be disabled while linking**
While `linkExistingMutation` is pending this button is still enabled, so a user who clicks "Reuse" and then immediately clicks "Connect a different GitHub org" can kick off a new OAuth flow while the link request is in flight. Consider disabling or hiding it when `linkExistingMutation.isPending`.
```suggestion
<Button
size="1"
variant="ghost"
color="gray"
loading={isConnecting}
disabled={linkExistingMutation.isPending}
onClick={() => void handleConnectGitHub()}
>
Connect a different GitHub org
<ArrowSquareOut size={12} />
</Button>
```
How can I resolve this? If you propose a fix, please make it concise.| githubAccountName: source.config?.account?.name ?? null, | ||
| }; | ||
| }, [alternativeConnectedProject]); | ||
| const alternativeSourceIntegrationId = alternativeSource?.id ?? null; |
There was a problem hiding this comment.
alternativeSourceIntegrationId is redundant
alternativeSourceIntegrationId is just alternativeSource?.id ?? null. Since alternativeSource already exposes id, this extra variable violates OnceAndOnlyOnce — callers can use alternativeSource?.id ?? null directly or check alternativeSource !== null to gate the "Reuse" button.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 109
Comment:
**`alternativeSourceIntegrationId` is redundant**
`alternativeSourceIntegrationId` is just `alternativeSource?.id ?? null`. Since `alternativeSource` already exposes `id`, this extra variable violates OnceAndOnlyOnce — callers can use `alternativeSource?.id ?? null` directly or check `alternativeSource !== null` to gate the "Reuse" button.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
k11kirky
force-pushed
the
04-29-feat_allow_user_to_use_existing_integration_to_connect_in_pc
branch
from
8d5fc9a to
4ed00cc
Compare
Aligns with the matching backend change in PostHog #57029, which switched from accepting an integration row id to accepting a sibling team id. The team id is already collected in availableInstallations, so this just renames the parameter and drops the now-unused sourceIntegrationId field from the dedupe map. Generated-By: PostHog Code Task-Id: f5372c83-7ea4-41dd-8f04-71191dff5782
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes