Open
Conversation
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/main/utils/fixPath.test.ts
Line: 69-164
Comment:
**Prefer parameterised tests for shared assertion patterns**
Tests `"merges fallback paths when shell PATH lacks /opt/homebrew/bin"` (line 69), `"falls back to fallback paths when shell resolution fails entirely"` (line 92), and `"merges fallback paths into a cached PATH that lacks them"` (line 106) all end with the same four `toContain` assertions for the fallback paths. Per the team's stated preference for parameterised tests, these cases could be collapsed into a single `it.each` that varies the mock setup (shell success / shell fail / cache hit) while sharing the assertion block, eliminating the duplication.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix: use merge path for users of oh my z..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+69
to
+164
|
|
||
| it("merges fallback paths when shell PATH lacks /opt/homebrew/bin", async () => { | ||
| mockSpawnSync.mockReturnValue({ | ||
| status: 0, | ||
| stdout: shellOutput("/usr/local/bin:/usr/bin:/bin"), | ||
| }); | ||
|
|
||
| const { fixPath } = await import("./fixPath"); | ||
| fixPath(); | ||
|
|
||
| const parts = process.env.PATH?.split(":") ?? []; | ||
| expect(parts).toContain("/opt/homebrew/bin"); | ||
| expect(parts).toContain("/opt/homebrew/sbin"); | ||
| expect(parts).toContain("/usr/local/bin"); | ||
| expect(parts).toContain("/usr/bin"); | ||
| }); | ||
|
|
||
| it("does not duplicate fallback paths already present in shell PATH", async () => { | ||
| mockSpawnSync.mockReturnValue({ | ||
| status: 0, | ||
| stdout: shellOutput("/opt/homebrew/bin:/usr/local/bin:/usr/bin"), | ||
| }); | ||
|
|
||
| const { fixPath } = await import("./fixPath"); | ||
| fixPath(); | ||
|
|
||
| const parts = process.env.PATH?.split(":") ?? []; | ||
| const homebrewCount = parts.filter((p) => p === "/opt/homebrew/bin").length; | ||
| expect(homebrewCount).toBe(1); | ||
| const usrLocalCount = parts.filter((p) => p === "/usr/local/bin").length; | ||
| expect(usrLocalCount).toBe(1); | ||
| }); | ||
|
|
||
| it("falls back to fallback paths when shell resolution fails entirely", async () => { | ||
| mockSpawnSync.mockReturnValue({ status: 1, stdout: "" }); | ||
|
|
||
| const { fixPath } = await import("./fixPath"); | ||
| fixPath(); | ||
|
|
||
| const parts = process.env.PATH?.split(":") ?? []; | ||
| expect(parts).toContain("/opt/homebrew/bin"); | ||
| expect(parts).toContain("/opt/homebrew/sbin"); | ||
| expect(parts).toContain("/usr/local/bin"); | ||
| expect(parts).toContain("/usr/bin"); | ||
| }); | ||
|
|
||
| it("merges fallback paths into a cached PATH that lacks them", async () => { | ||
| mockExistsSync.mockReturnValue(true); | ||
| mockReadFileSync.mockReturnValue( | ||
| JSON.stringify({ | ||
| path: "/usr/local/bin:/usr/bin:/bin", | ||
| timestamp: Date.now(), | ||
| }), | ||
| ); | ||
|
|
||
| const { fixPath } = await import("./fixPath"); | ||
| fixPath(); | ||
|
|
||
| const parts = process.env.PATH?.split(":") ?? []; | ||
| expect(parts).toContain("/opt/homebrew/bin"); | ||
| expect(mockSpawnSync).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it("ignores stale cache and re-resolves via shell", async () => { | ||
| mockExistsSync.mockReturnValue(true); | ||
| mockReadFileSync.mockReturnValue( | ||
| JSON.stringify({ | ||
| path: "/some/old/path", | ||
| timestamp: Date.now() - 2 * 60 * 60 * 1000, | ||
| }), | ||
| ); | ||
| mockSpawnSync.mockReturnValue({ | ||
| status: 0, | ||
| stdout: shellOutput("/usr/local/bin:/usr/bin"), | ||
| }); | ||
|
|
||
| const { fixPath } = await import("./fixPath"); | ||
| fixPath(); | ||
|
|
||
| expect(mockSpawnSync).toHaveBeenCalled(); | ||
| const parts = process.env.PATH?.split(":") ?? []; | ||
| expect(parts).not.toContain("/some/old/path"); | ||
| expect(parts).toContain("/opt/homebrew/bin"); | ||
| }); | ||
|
|
||
| it("returns early on win32 without touching PATH", async () => { | ||
| setPlatform("win32"); | ||
| process.env.PATH = "C:\\Windows\\System32"; | ||
|
|
||
| const { fixPath } = await import("./fixPath"); | ||
| fixPath(); | ||
|
|
||
| expect(mockSpawnSync).not.toHaveBeenCalled(); | ||
| expect(process.env.PATH).toBe("C:\\Windows\\System32"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Tests "merges fallback paths when shell PATH lacks /opt/homebrew/bin" (line 69), "falls back to fallback paths when shell resolution fails entirely" (line 92), and "merges fallback paths into a cached PATH that lacks them" (line 106) all end with the same four toContain assertions for the fallback paths. Per the team's stated preference for parameterised tests, these cases could be collapsed into a single it.each that varies the mock setup (shell success / shell fail / cache hit) while sharing the assertion block, eliminating the duplication.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/main/utils/fixPath.test.ts
Line: 69-164
Comment:
**Prefer parameterised tests for shared assertion patterns**
Tests `"merges fallback paths when shell PATH lacks /opt/homebrew/bin"` (line 69), `"falls back to fallback paths when shell resolution fails entirely"` (line 92), and `"merges fallback paths into a cached PATH that lacks them"` (line 106) all end with the same four `toContain` assertions for the fallback paths. Per the team's stated preference for parameterised tests, these cases could be collapsed into a single `it.each` that varies the mock setup (shell success / shell fail / cache hit) while sharing the assertion block, eliminating the duplication.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes