refactor: clean up ReportTaskLogs and fix bar expand/collapse#1918
Open
oliverb123 wants to merge 4 commits intomainfrom
Open
refactor: clean up ReportTaskLogs and fix bar expand/collapse#1918oliverb123 wants to merge 4 commits intomainfrom
oliverb123 wants to merge 4 commits intomainfrom
Conversation
Extract BarRow + buildBars out of the inline render, drive bar order from a single BAR_ORDER constant, and use a uniform <div role="button"> for every interactive bar so clicking the same bar in the expanded state reliably collapses it — and so research expands cleanly when an implementation task is also present. Generated-By: PostHog Code Task-Id: 6b2b677f-e9c9-4028-b37e-d92158107040
|
Reviews (1): Last reviewed commit: "refactor: clean up ReportTaskLogs and fi..." | Re-trigger Greptile |
The card had `pointer-events-none` with `pointer-events-auto` re-enabled on the bars container. That click-through dance was unnecessary (the card has no empty area — bars + TaskLogsPanel fill it) and was what was preventing clicks from reliably reaching the bar in the expanded state. Removed it on the card, the bars container, and the expanded body, leaving everything inside the card with default pointer-events. Adds a focused unit test that asserts: same-bar click collapses, the research bar expands when a completed implementation task is also present, and clicking a different bar while one is expanded switches. Generated-By: PostHog Code Task-Id: 6b2b677f-e9c9-4028-b37e-d92158107040
…ested A native <button> is the most reliable click target across Chromium — falls back to <div role="button"> only when a run-action button has to be nested inside (HTML disallows nested <button>s). Generated-By: PostHog Code Task-Id: 6b2b677f-e9c9-4028-b37e-d92158107040
…-index Belt-and-suspenders against any absolute child of SessionView that might escape its container and end up over the bars. Adds an opaque background to the bar container so nothing visually peeks through either. Generated-By: PostHog Code Task-Id: 6b2b677f-e9c9-4028-b37e-d92158107040
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReportTaskLogsin the inbox report detail panel: pullsBarRowandbuildBarsout of the inline render, drives ordering from a singleBAR_ORDERconstant (top-to-bottom), and removes the deadDISPLAYED_RELATIONSHIPSsort that contradicted the actual push order.<div role="button">(instead of conditionally toggling between<button>and<div role="button">depending on whether a run-action button is present). This makes the click-to-toggle behavior consistent across all states — clicking the same bar in the expanded state now reliably collapses it, and clicking research expands cleanly even when the implementation task is also present.BarRelationshipexcludesrepo_selection) and renames the open state (isOpen,collapse,toggle) so the JSX reads cleanly.No behavioral change to the sliding card, scrim, or PR/run-action buttons.
Test plan
pending_inputreport, the "Provide input for PR" run button still works and doesn't collapse the barGenerated-By: PostHog Code
Task-Id: 6b2b677f-e9c9-4028-b37e-d92158107040