feat: enhance log storage configuration with existing secret support#199
Closed
avaya09 wants to merge 4 commits into
Closed
feat: enhance log storage configuration with existing secret support#199avaya09 wants to merge 4 commits into
avaya09 wants to merge 4 commits into
Conversation
Contributor
avaya09
commented
May 20, 2026
avaya09
commented
- Added support for using an existing Kubernetes Secret for log storage credentials in values.yaml.
- Updated secret management in templates to reference the new log storage secret.
- Expanded documentation to include expected keys for various log storage backends.
- Added support for using an existing Kubernetes Secret for log storage credentials in values.yaml. - Updated secret management in templates to reference the new log storage secret. - Expanded documentation to include expected keys for various log storage backends.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support to the portkey-app Helm chart for sourcing log storage credentials from an existing Kubernetes Secret, instead of always templating them into the chart-managed gateway Secret.
Changes:
- Added
logStorage.existingSecretNametovalues.yamlto enable referencing a pre-created Secret for log storage credentials. - Updated templates to (a) stop rendering log storage keys into the gateway Secret when an existing Secret is configured and (b) read log storage env vars from the existing Secret via a new helper.
- Expanded secret-manager integration docs to include example Secret sync and required key sets per log storage backend.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/portkey-app/values.yaml | Adds logStorage.existingSecretName value to support referencing an existing Secret. |
| charts/portkey-app/templates/gateway/secrets.yaml | Skips templating log storage credentials into the gateway Secret when an existing Secret is configured. |
| charts/portkey-app/templates/_helpers.tpl | Introduces helper to resolve the secret name for log storage env vars (existing secret vs gateway secret). |
| charts/portkey-app/docs/secret-manager-integration.md | Documents expected keys and provides an example for syncing log storage credentials into a Secret. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
12
| type: Opaque | ||
| data: | ||
| {{- if not .Values.logStorage.existingSecretName }} | ||
| {{- if .Values.logStorage.s3Compat.enabled}} |
…tes Secret - Introduced configuration options for reusing an existing Kubernetes Secret for bedrockAssumed credentials in values.yaml. - Updated documentation to reflect the new secret management for bedrockAssumed. - Enhanced templates to conditionally reference the existing secret for bedrockAssumed credentials.
Comment on lines
11
to
13
| data: | ||
| {{- if not .Values.logStorage.existingSecretName }} | ||
| {{- if .Values.logStorage.s3Compat.enabled}} |
Comment on lines
+384
to
+386
| The `logStore` key value encodes the backend type — one of `s3_compat`, | ||
| `s3_assume`, `mongo`, or `azure`. The two overrides are independent: you can | ||
| use an existing Secret for one and let the chart manage the other. |
- Modified the conditional logic in secrets.yaml to ensure proper handling of existing secrets for both log storage and bedrockAssumed credentials. - This change enhances the flexibility of secret management in the gateway configuration.
|
|
||
| logStorage: | ||
| logStore: "s3_custom" | ||
| logStore: "s3Compat" |
Comment on lines
+384
to
+385
| The `logStore` key value encodes the backend type — one of `s3_compat`, | ||
| `s3_assume`, `mongo`, or `azure`. The two overrides are independent: you can |
- Changed the logStore value from s3Compat to s3_custom in openshift.yaml to reflect the new naming convention. - Updated documentation to clarify the available logStore options, including the addition of s3_custom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.