Select the parent of the script containing import.meta.document#15
Select the parent of the script containing import.meta.document#15aaronmars wants to merge 1 commit intoPolymerLabs:masterfrom
import.meta.document#15Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| @@ -51,7 +51,7 @@ export const htmlModuleToJsModuleMap = | |||
|
|
|||
| if (property.type === 'Identifier') { | |||
There was a problem hiding this comment.
I think the problem here is that this check is not specific enough. The condition is checking for usages of import.meta.* as an expression, but isn't particular about import.meta.script (the original use case) vs import.meta.document.
We should probably change the condition to something like:
if (property.type === 'Identifier') {
switch (property.name) {
case 'script':
// Do the current transform for script
break;
case 'document':
// Do the new proposed transform for document
break;
}
}|
Thanks for looking into this 🙌 left a note, LMKWYT! |
|
Oh yeah. Wow. I completely mis-read the code there. Makes sense now! |
See #14.
Aligns the transform for import.meta.document with the explainer/proposal at https://github.com/w3c/webcomponents/blob/gh-pages/proposals/html-modules-explainer.md