fix: handle non-alphanumeric characters in infer_pattern (#102)#103
Merged
sameeul merged 1 commit intoPolusAI:masterfrom Mar 12, 2026
Merged
Conversation
Fixed RuntimeError when inferring patterns from files with special characters (periods, hyphens, underscores) in their names, particularly affecting files with .ome.tif extensions. The pattern inference algorithm now properly checks if non-alphanumeric characters match before throwing an error, allowing them to be included in the inferred pattern. Changes: - Modified swSearch traceback logic in pattern.cpp to handle matching special characters - Added comprehensive regression tests in test_inferpattern_special_chars.py Fixes PolusAI#102 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed RuntimeError when inferring patterns from files with special characters (periods, hyphens, underscores) in their names, particularly affecting files with .ome.tif extensions.
The pattern inference algorithm now properly checks if non-alphanumeric characters match before throwing an error, allowing them to be included in the inferred pattern.
Changes:
Fixes #102