Add external CTC child benchmarks to national validation#742
Open
Add external CTC child benchmarks to national validation#742
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctc_qualifying_childrenWhy
Recent CTC follow-up work showed that the remaining instability is compositional. We now have a better validator for artifact-to-artifact drift in #731, but we still need some source-backed external anchors for the child composition itself.
This PR adds the public-source pieces that look defensible now:
ctc_qualifying_childrenfrom 2022 Publication 4801 Schedule 8812 line 4 amountsIt deliberately does not add the 2021 under-6 split as a hard target because that source is tied to the ARPA/advance-CTC under-18 concept rather than the current-law under-17 concept used by
ctc_qualifying_child.Issue tracking
Testing
uv run pytest tests/unit/calibration/test_validate_national_h5.py -quv run ruff check policyengine_us_data/calibration/validate_national_h5.py tests/unit/calibration/test_validate_national_h5.pyuv run ruff format --check policyengine_us_data/calibration/validate_national_h5.py tests/unit/calibration/test_validate_national_h5.pyuv run python -m policyengine_us_data.calibration.validate_national_h5 --help