Fix unicity of flavor texts and version names#1490
Open
Dropries wants to merge 5 commits intoPokeAPI:masterfrom
Open
Fix unicity of flavor texts and version names#1490Dropries wants to merge 5 commits intoPokeAPI:masterfrom
Dropries wants to merge 5 commits intoPokeAPI:masterfrom
Conversation
jemarq04
suggested changes
Apr 16, 2026
Comment on lines
-381
to
+387
| 44,1,赤 | ||
| 44,3,레드 | ||
| 44,5,Rouge | ||
| 44,6,Rot | ||
| 44,7,Rojo | ||
| 44,8,Rossa | ||
| 44,9,Red | ||
| 44,1,赤 (ja) | ||
| 44,3,레드 (ja) | ||
| 44,5,Rouge (ja) | ||
| 44,6,Rot (ja) | ||
| 44,7,Rojo (ja) | ||
| 44,8,Rossa (ja) | ||
| 44,9,Red (ja) |
Contributor
There was a problem hiding this comment.
I don't think the prose would need to be unique, but if so I think this brings up an interesting question. I would say Pokemon Red would be better titled an international version of Red instead of calling this the Japanese version.
@Naramsim what do you think? Should the uniqueness of the prose be a concern and if so what would you think is best?
Contributor
|
Just noticed this was a draft so maybe the review was premature lol. Feel free to continue working on this of course! |
…id' columnsi for moves : fix version_group_id of the descriptions from the teal mask and the indigo disk for abilities : remove the descriptions that does not correspond to the correct version_group_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
*_flavor_text.csvfile contains a unique translation for each combination of*_idcolumnsAI coding assistance disclosure
No AI coding has been used.
Contributor check list