fix cuda 13.3 errors#6443
Open
jmackay2 wants to merge 1 commit into
Open
Conversation
Member
|
Thank you for the fix. However, I have to say I am a bit hesitant to put these three function into the #if THRUST_MAJOR_VERSION >= 3
#include <cuda/std/tuple>
namespace pcl_thrust {
using ::cuda::std::tuple;
using ::cuda::std::make_tuple;
using ::cuda::std::get;
}
#else
namespace pcl_thrust {
using ::thrust::tuple;
using ::thrust::make_tuple;
using ::thrust::get;
}
#endifAnd change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to CUDA 13.3 included an update of thrust. This resulted in the following build failures in the cuda module:
This fixes the issue by switching to use
cuda::stdinstead ofthrustwhen there is a newer version of thrust.Testing
This was tested by building on Ubuntu 24.04 with both CUDA 12.9 and 13.3.