Fix the bug where warhead flags are read twice#2128
Open
DeathFishAtEase wants to merge 1 commit intoPhobos-developers:developfrom
Open
Fix the bug where warhead flags are read twice#2128DeathFishAtEase wants to merge 1 commit intoPhobos-developers:developfrom
DeathFishAtEase wants to merge 1 commit intoPhobos-developers:developfrom
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Contributor
|
What exactly causes it to be read twice? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does anyone know why repeated loading is necessary? I discovered this while handling #2093 and suspect it is a bug.
By switching to the
developbranch and adding log inWarheadTypeExt::ExtData::LoadFromINIFile, it can be observed that each warhead is loaded twice.For example, based on 6035b7b, make the following modifications:
void WarheadTypeExt::ExtData::LoadFromINIFile(CCINIClass* const pINI) { auto pThis = this->OwnerObject(); const char* pSection = pThis->ID; + static std::map<uintptr_t, int> iniCallCount; + uintptr_t iniAddr = reinterpret_cast<uintptr_t>(pINI); + int count = ++iniCallCount[iniAddr]; + Debug::Log("[DEBUG] LoadFromINIFile for [%s] count: %d\n", pSection, count); INI_EX exINI(pINI);In

debug.log, it can be observed: