Skip to content

Add toggle of whether shield use ArmorMultiplier or not#2126

Open
NetsuNegi wants to merge 6 commits intoPhobos-developers:developfrom
NetsuNegi:branch/shield_use_armormultiplier
Open

Add toggle of whether shield use ArmorMultiplier or not#2126
NetsuNegi wants to merge 6 commits intoPhobos-developers:developfrom
NetsuNegi:branch/shield_use_armormultiplier

Conversation

@NetsuNegi
Copy link
Contributor

@NetsuNegi NetsuNegi commented Mar 2, 2026

In rulesmd.ini:

[CombatDamage]
ShieldApplyArmorMultiplier=false            ; boolean

[SOMESHIELDTYPE]                            ; ShieldType name
ApplyArmorMultiplier=                       ; boolean, default to [CombatDamage] -> ShieldApplyArmorMultiplier

@NetsuNegi NetsuNegi added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot
Copy link

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/206/1

@Coronia
Copy link
Contributor

Coronia commented Mar 2, 2026

tag names should be ApplyArmorMult for consistency

@NetsuNegi NetsuNegi requested a review from TaranDahl March 2, 2026 05:15
Copy link
Contributor

@TaranDahl TaranDahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought of a new issue. If the shield doesn't fully absorb the damage, does the armor modifier take effect twice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs testing ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants