Fix inconsistency between GapGen and SpySat causing desyncs#2115
Open
Starkku wants to merge 3 commits intoPhobos-developers:developfrom
Open
Fix inconsistency between GapGen and SpySat causing desyncs#2115Starkku wants to merge 3 commits intoPhobos-developers:developfrom
Starkku wants to merge 3 commits intoPhobos-developers:developfrom
Conversation
Starkku
force-pushed
the
fix/gap-spysat-cellchecks
branch
2 times, most recently
from
8062df0 to
75c813c
Compare
Starkku
force-pushed
the
fix/gap-spysat-cellchecks
branch
from
75c813c to
baecb18
Compare
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
added
Needs testing
Needs MP testing
Contributor
Contributor
Author
|
FYI this was supposed to merely be an alternate approach to the issue and not decisively better one, that would have warranted further discussion which I don't think reached a proper conclusion. I did test it quickly in multiplayer with Kerbiter and the desync did seem to be gone, although having others test it too may not be the worst idea. |
Coronia
added
Tested
and removed
Needs testing
Needs MP testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate fix to #2111 that addresses the root cause. SpySat skips certain cells in multiplayer when revealing shroud, this replicates the same check for resetting shroud as well as creating/deleting gap.
Do not merge both this and #2111.