PKG-1208 Prepare packages for Percona Binlog Server#99
Open
adivinho wants to merge 3 commits intoPercona-Lab:mainfrom
Open
PKG-1208 Prepare packages for Percona Binlog Server#99adivinho wants to merge 3 commits intoPercona-Lab:mainfrom
adivinho wants to merge 3 commits intoPercona-Lab:mainfrom
Conversation
| dnf module disable mysql -y | ||
| fi | ||
| percona-release enable ps-84-lts release | ||
| yum -y install percona-server-devel |
Collaborator
There was a problem hiding this comment.
I think we can limit this to libmysqlclient-devel or corresponding package for Percona Server
| percona-release enable pdps-84-lts release | ||
| apt-get install -y cmake autotools-dev autoconf automake build-essential devscripts debconf debhelper fakeroot | ||
| if [ "${OS_NAME}" == "bullseye" ]; then | ||
| apt-get install -y ca-certificates xz-utils |
Collaborator
There was a problem hiding this comment.
In the main project CMakeLists.txt I put cmake_minimum_required(VERSION 3.20) only because it was the default version of CMake package on a platform where I started. There is a chance that this requirement can be relaxed.
| ( | ||
| %if 0%{?amzn} | ||
| echo "Running Amazon Linux–specific command" | ||
| sed -i 's:gcc-14:gcc14-gcc:' ../percona-binlog-server-%{version}/extra/cmake_presets/boost/CMakePresets.json |
Collaborator
There was a problem hiding this comment.
If it helps, I can add two more Preset to CMakePresets.json that would be called GCC Default RelWithDebInfo / GCC Default Debug. They would be referring to default gcc /g++.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.