Add GET /lookups/ranges endpoint for lookup range brackets #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/tenants/{tenantId}/payrolls/{payrollId}/lookups/rangesendpoint that returns lookup range brackets with computed upper boundsLookupSetExtensionsbut previously not accessible via the APIMotivation
Current lookup endpoints return either raw values (without computed bounds) or a single matched value. There is no way to retrieve the complete bracket structure (lower + upper bounds) through the API. This is needed for contribution preview in salary simulation case (For example, giving visibility of the social contribution threshold based on employee cases).
New endpoint
Returns
LookupRangeResult[]withallBrackets,matchingBracket(threshold),matchingBrackets(progressive).Changes
LookupRangeBracket.cs,LookupRangeResult.cs,LookupSetExtensions.csBuildRangeBrackets()methodLookupRangeBracket.cs,LookupRangeResult.csLookupRangeBracketMap.cs,LookupRangeResultMap.csPayrollController.csPayrollController.cs[HttpGet("{payrollId}/lookups/ranges")]Test plan
dotnet buildpasses with TreatWarningsAsErrorsdotnet testpassesmatchingBracketreturned for a givenrangeValuematchingBracketsreturnedrangeSizefor last bracket)lookupNames