Skip to content

Add Architectural Decision Governance rule#302

Open
TheoV823 wants to merge 1 commit into
PatrickJS:mainfrom
TheoV823:add-architectural-decision-governance
Open

Add Architectural Decision Governance rule#302
TheoV823 wants to merge 1 commit into
PatrickJS:mainfrom
TheoV823:add-architectural-decision-governance

Conversation

@TheoV823

@TheoV823 TheoV823 commented Jun 4, 2026

Copy link
Copy Markdown

Adds a reusable Cursor Project Rule: rules/architectural-decision-governance.mdc.

For teams that record architectural decisions (ADRs) and want AI-generated changes to respect them. The rule treats recorded decisions as binding constraints and gives the assistant a short set of checks before it writes: respect recorded decisions, extend instead of rebuild, do not reintroduce rejected choices, stay inside the chosen stack, and surface conflicts early.

  • Flat .mdc in rules/, globs: ["**/*"], alwaysApply: false, matching the existing discipline rules (Anti-Over-Engineering, Anti-Sycophancy Code Discipline).
  • README entry added under Build Tools and Development, alphabetically after Anti-Sycophancy Code Discipline.
  • Self-contained: useful without clicking any link.

Summary by CodeRabbit

  • Documentation

    • Added architectural decision governance documentation outlining constraints for code consistency and alignment with established design decisions.
  • Chores

    • Updated build tools reference guide to include the new architectural governance ruleset.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4dfae4b0-fdb5-4dbc-853d-2e2b9e976ed3

📥 Commits

Reviewing files that changed from the base of the PR and between b044f95 and fba179e.

📒 Files selected for processing (2)
  • README.md
  • rules/architectural-decision-governance.mdc

📝 Walkthrough

Walkthrough

This PR adds a new architectural decision governance rule to the Cursor rules repository. A new architectural-decision-governance.mdc file defines constraints requiring AI-generated code to respect recorded architectural decisions, extend rather than duplicate abstractions, and escalate unresolved choices. The README index was updated to reference the new rule.

Changes

Architectural Decision Governance Rule

Layer / File(s) Summary
Rule definition and documentation
rules/architectural-decision-governance.mdc, README.md
New ruleset defines constraints for checking AI code against recorded ADRs, handling conflicts, and escalation guidance. README entry added to "Build Tools and Development" section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • PatrickJS

Poem

A rabbit hops through rules so clear,
Decisions mapped, no doubts need fear,
Architectural wisdom, now in place,
Guiding code through decision's space. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new architectural decision governance rule file.
Description check ✅ Passed The description covers all required template sections with specific details about the rule's purpose, file structure, and implementation approach.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant