fix: add arrow key command history navigation for macOS/Linux console#1013
Open
SaraBelle117 wants to merge 1 commit intoPathoschild:developfrom
Open
fix: add arrow key command history navigation for macOS/Linux console#1013SaraBelle117 wants to merge 1 commit intoPathoschild:developfrom
SaraBelle117 wants to merge 1 commit intoPathoschild:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change: Adds arrow key command history navigation for macOS/Linux console input. On Windows this works natively, but on macOS/Linux SMAPI uses
Console.ReadLine()which doesn't handle arrow key escape sequences. This replaces it with aConsole.ReadKey()loop on non-Windows platforms that tracks command history and allows up/down arrow navigation.Related Issue: #1000
How it works:
Console.ReadKey()Note: I'm aware this is a new feature and that discussing on Disord first is recommended. This PR was submitted as part of a class assignment and may not be suitable for merging as-is, but feedback is welcome!