Skip to content

Support importing characters from PoE API#845

Merged
Wires77 merged 28 commits into
devfrom
oauth
Apr 6, 2025
Merged

Support importing characters from PoE API#845
Wires77 merged 28 commits into
devfrom
oauth

Conversation

@Wires77

@Wires77 Wires77 commented Mar 28, 2025

Copy link
Copy Markdown
Member

Initially copied from: PathOfBuildingCommunity/PathOfBuilding#8525

This is a very early implementation of PoB interacting with PoE's OAuth API. I wanted to get this out there in draft for early reviews and to organize my thoughts while I check things off the list:

Required for MVP:

  • TODO statements
  • Hardening/Logging
  • Investigate if SO_EXCLUSIVEADDRUSE is set in luasocket (part of hardening)
    -- Pretty sure this only applies to pre-Windows 2003 installs and people running PoB in compatibility mode for that. I did submit a PR to luasocket before realizing that, but I may not need to bake it into PoB's implementation
  • Automatic token acquisition on 401 error
  • Add luasocket license
  • Open SimpleGraphic PR for luasocket artifacts
  • Server start and timeout messaging/UX

Future goals:

  • Secure token storage
  • Refresh token usage and storage
  • Investigate behavior and QoL with multiple PoB instances open (Access token currently stored in memory, focus PoB window when redirect is made, etc)

@Wires77 Wires77 marked this pull request as draft March 28, 2025 02:39
@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 4, 2025
@Wires77 Wires77 marked this pull request as ready for review April 4, 2025 19:55
@Wires77 Wires77 merged commit 4e32fb1 into dev Apr 6, 2025
@LocalIdentity LocalIdentity deleted the oauth branch April 6, 2025 03:42
bct8925 pushed a commit to bct8925/PathOfBuilding-PoE2 that referenced this pull request Jun 19, 2026
* Initial commit of OAuth2 code

* Support item import (minus runes)

* Add SetForeground function after OAuth flow

* Rebuild SimpleGraphic DLL

* Skills Gems imported

* InernalId was added o enable importing from poe api

* InernalId was added o enable importing from poe api v2

* Passive tree: Nodes, Weaponset and Attributes imported

* Jewel Slots import was enabled

* LaunchServer Response OK was improved

* POE API: Workflow for validad and refresh tokens when it can added

* POE API: Workflow fixed when yout try to import items

* POE API: Intarnal names mapped with public names was added

* Fix colors for new PoE2 classes, making the process more generic

* Support importing socketed runes

* Increment retries

* Add tokenExpiry, generate state parameter

* POE API: Token Expiry for validation was added

* POE API: Save response to file was added

* POE API: Importing a JSON in devMode was added

* Implemented rate limiting

* Cleanup logs and docs, some small bugs

* Remove debug lines

* Skip account and realm selection page, better handle errors

* Fix crash on 429 error

* Change response file name and fix typo

---------

Co-authored-by: justjuangui <servicios@juacarvajal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants