Skip to content

Add option to return to build selection when crashing#2230

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:error-escape
Jun 26, 2026
Merged

Add option to return to build selection when crashing#2230
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:error-escape

Conversation

@vaisest

@vaisest vaisest commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Fixes issues where users encounter an issue which crashes PoB when loading. This is obviously not very common, but in cases such as #2217 can cause PoB to crash when loading, which renders both the dismiss and restart options useless. There can also be crashes in Draw functions, such as when it happened to timeless jewels at the start of 0.5 due to missing textures.

This option lets users at least continue using PoB without having to manually remove the problematic profile file, which they probably won't know to do.

Steps taken to verify a working solution:

  • Yes
  • Can be tested by e.g. adding an error() to a tab's Draw method

Link to a build that showcases this PR:

https://pobb.in/wS-S5R5EYZfC (#2217 build which crashes)

Before screenshot:

image

After screenshot:

image

@LocalIdentity LocalIdentity added enhancement New feature, calculation, or mod pob1 Should also be merged into PoB1 Repo labels Jun 19, 2026
When a crash happened in a popup, it would not clear the popup on pressing f4 so would still be stuck in a crash loop
e.g. Crash in the item set manager popup UI
We now clear the popup events and input events just incase

@LocalIdentity LocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a small issue when a crash occurred inside a popup, but this is a good fix to have for the future

@LocalIdentity LocalIdentity merged commit 2c3eff7 into PathOfBuildingCommunity:dev Jun 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod pob1 Should also be merged into PoB1 Repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants