Loading indicator improvements to audit search and filtering#3047
Open
ngallegos wants to merge 15 commits into
Open
Loading indicator improvements to audit search and filtering#3047ngallegos wants to merge 15 commits into
ngallegos wants to merge 15 commits into
Conversation
…filtered after the first load
boblangley
requested changes
Jul 2, 2026
Member
|
Tamara and I are going to push a commit for a new direction. AuditList knows if a query is running. It should disable all of the form fields that can trigger a new query. We will abandon the 1 second refresh because now there is a loading spinner. A future feature can add cancellation which is probably needed. |
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
Co-authored-by: Tamara Rivera <tamita.rivera@gmail.com>
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
tamararivera
reviewed
Jul 2, 2026
Prettier hates me Co-authored-by: Tamara Rivera <tamita.rivera@gmail.com>
tamararivera
reviewed
Jul 3, 2026
Co-authored-by: Tamara Rivera <tamita.rivera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When HTTP calls to ServiceControl take longer than expected, the audit messages view does not make it clear that the user is waiting for something to finish. This introduces some UI improvements to help with that:
Reviewer Checklist