Skip to content

Better error management for Azure Service Bus usage collection#5228

Merged
andreasohlund merged 9 commits into
masterfrom
asb-metrics
Dec 17, 2025
Merged

Better error management for Azure Service Bus usage collection#5228
andreasohlund merged 9 commits into
masterfrom
asb-metrics

Conversation

@andreasohlund
Copy link
Copy Markdown
Member

@andreasohlund andreasohlund commented Dec 12, 2025

We now only look for the metric we asked for and also surface any errors in the .Errors property of the response

@andreasohlund andreasohlund modified the milestones: vNext, 6.9.0 Dec 16, 2025
Comment thread src/ServiceControl.Transports.ASBS/AzureQuery.cs Outdated
ArmEnvironment.AzurePublicCloud, ArmEnvironment.AzureGermany, ArmEnvironment.AzureGovernment,
ArmEnvironment.AzureChina
}.Select(armEnvironment => $"\"{armEnvironment.Endpoint}\""));
new[] { ArmEnvironment.AzurePublicCloud, ArmEnvironment.AzureGermany, ArmEnvironment.AzureGovernment, ArmEnvironment.AzureChina }.Select(environment => $"\"{environment.Endpoint}\""));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Comment thread src/ServiceControl.Transports.ASBS/AzureQuery.cs
Comment thread src/ServiceControl.Transports.ASBS/AzureQuery.cs Outdated
Comment thread src/ServiceControl.Transports.ASBS/AzureQuery.cs
@andreasohlund andreasohlund enabled auto-merge (squash) December 17, 2025 11:55
@andreasohlund andreasohlund merged commit 0a279b7 into master Dec 17, 2025
32 checks passed
@andreasohlund andreasohlund deleted the asb-metrics branch December 17, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants