add option to disable keybindings fixing #1251#1254
Merged
jbtronics merged 5 commits intoPart-DB:masterfrom Feb 28, 2026
Merged
add option to disable keybindings fixing #1251#1254jbtronics merged 5 commits intoPart-DB:masterfrom
jbtronics merged 5 commits intoPart-DB:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
============================================
- Coverage 54.77% 54.59% -0.18%
- Complexity 8012 8107 +95
============================================
Files 601 606 +5
Lines 25690 26014 +324
============================================
+ Hits 14072 14203 +131
- Misses 11618 11811 +193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The tests are already enforced by type declarations
Member
|
Thanks. Ideally this should be configurable on a per-user level, but this way is fine for now. |
mkne
pushed a commit
to mkne/Part-DB-server
that referenced
this pull request
Mar 5, 2026
* add option to disable keybindings * add tests for disabling keybindings * Fixed translation keys * Added env to env configuration list * Removed useless tests The tests are already enforced by type declarations --------- Co-authored-by: Jan Böhmer <mail@jan-boehmer.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would fix #1251
The keybindings conflict with important characters on Mac keyboards.
Currently for example
{}always get replaced with ´©{¥}`, especially problematic in workflows using barcode scanners.