Merged
Conversation
…with a general problem instead
erikvansebille
approved these changes
Mar 3, 2026
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Looks good. And nice also that you added tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As flagged by @ammedd in class, it was possible for an instrument 'problem' to occur at a waypoint where this instrument is not deployed. Therefore, this PR introduces additional logic to the problems selection procedure to ensure that the instrument associated with a given
InstrumentProblemis actually present at the waypoint it has been assigned. The original waypoint assignment is random.Note, instead of finding a replacement waypoint to assign, the
InstrumentProblemis replaced with aGeneralProblemwhich can occur at any waypoint. This is because there are situations, albeit rare, when there is no other available and suitable waypoint.