Conversation
for more information, see https://pre-commit.ci
…p into instruments-null
for more information, see https://pre-commit.ci
erikvansebille
approved these changes
Mar 3, 2026
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Again, I assume that the test fails on the old code?
Collaborator
Author
Yes, indeed, the previous version fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the waypoint instruments handling in
_calc_wp_stationkeeping_time()to be able to properly handleinstrument: nullat a waypoint in the expedition.yaml.Convert
expedition.schedule.instrumentto an empty list when it isnullin YAML.nullis takenasNoneTypein Python and cannot be used for the various checks later in the function.