[BugFix] Seperate prometheus multiproc dir for single-server multi-dp services#8059
[BugFix] Seperate prometheus multiproc dir for single-server multi-dp services#8059liyonghua0910 wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #8059 +/- ##
==========================================
Coverage ? 67.48%
==========================================
Files ? 475
Lines ? 66959
Branches ? 10332
==========================================
Hits ? 45184
Misses ? 18892
Partials ? 2883
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d1ec8f0 to
15b4d28
Compare
CI报告基于以下代码生成(30分钟更新一次): 1 Required任务 : 8/10 通过
2 失败详情🔴 Run FastDeploy Unit Tests and Coverage / run_tests_with_coverage — PR问题(置信度: 高)错误类型: PR问题 | 置信度: 高
关键日志:
修复建议:
关联变更: 🔴 Approval — 需要 Approval(置信度: 高)该 Job 需要人工 Approval,完成审批后 CI 才会继续执行。 |
15b4d28 to
13e5962
Compare
13e5962 to
9a08ce4
Compare
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-07-06 16:21:53
📋 Review 摘要
PR 概述:为单机多 DP 服务拆分 Prometheus multiprocess 目录,避免多个 DP rank 共享 .db 文件。
变更范围:Engine DP 子进程启动、OpenAI multi API server、Prometheus multiprocess 初始化与测试。
影响面 Tag:[Engine] [APIServer]
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🔴 Bug | fastdeploy/engine/engine.py:910 |
单 server 多 DP 最终只从 dp0 目录采集 metrics,DP1+ 指标会被遗漏 |
| 🔴 Bug | fastdeploy/engine/common_engine.py:2783 |
EngineService 同类启动路径也只暴露 dp0 metrics |
📝 PR 规范检查
符合规范。
总体评价
目录隔离方向合理,但采集端没有同步支持多 DP 子目录聚合。当前实现会让单 server 多 DP 场景的 /metrics 丢失非 DP0 rank 指标,需要修复后再合入。
Motivation
Fix metric interference when multiple data-parallel services run on one server by isolating Prometheus multiprocess files per DP rank.
Modifications
PROMETHEUS_MULTIPROC_DIRset during metrics initialization.setup_dp_prometheus_dir()to create per-DPdp{i}subdirectories and switch the target environment.LLMEngine/EngineServiceand whenmulti_api_serverstarts per-DP API server processes.Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.