Skip to content

🪲 [Fix]: Connect-GitHubApp no longer fails when only one installation exists #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marius Storhaug (MariusStorhaug) merged 3 commits into from
Apr 2, 2026
+1 −1
Merged

🪲 [Fix]: Connect-GitHubApp no longer fails when only one installation exists #568

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2df5ccd
Fix Connect-GitHubApp AddRange failure with single installation
MariusStorhaug Mar 29, 2026
b11a143
Fix PSAlignAssignmentStatement violations in single-key hashtables
MariusStorhaug Mar 29, 2026
d0ef98d
Merge branch 'main' into fix/567-connect-githubapp-single-installation
MariusStorhaug Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/functions/public/Auth/Connect-GitHubApp.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
}
default {
Write-Verbose 'No target specified. Connecting to all installations.'
$selectedInstallations.AddRange((Get-GitHubAppInstallation -Context $Context))
$selectedInstallations.AddRange(@(Get-GitHubAppInstallation -Context $Context))
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression coverage: this change fixes the single-installation case, but the current Pester suite appears to only exercise the default (no-parameter) path against whatever installations exist in the test environment, and doesn’t assert behavior when Get-GitHubAppInstallation yields exactly one object (the scenario that previously threw). Add a targeted test that forces a single-installation return (e.g., via a controlled fixture/mocking or a dedicated test app with exactly one installation) and asserts Connect-GitHubApp -PassThru does not throw and returns one context.

Copilot uses AI. Check for mistakes.
Write-Verbose "Found [$($selectedInstallations.Count)] installations."
}
}
Expand Down
Loading