fix: correct dotnet path filter in tests.yaml#5965
Merged
Conversation
The dotnet path filter pointed at prqlc/bindings/prql-dotnet/**, but the directory was renamed to prqlc/bindings/dotnet/** in #3683, so the filter has never matched dotnet-only changes — test-dotnet was being silently skipped on every dotnet-only PR. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnetpath filter intests.yamlso dotnet-only PRs actually runtest-dotnet. The filter pointed atprqlc/bindings/prql-dotnet/**, but the directory was renamed toprqlc/bindings/dotnet/**in refactor: reorganize dirs #3683 — so the filter has never matched dotnet-only changes since then.test-dotnetwould only run whenmain: true(i.e. workflow changes), so dotnet binding edits have been shipping unvalidated by CI.Follow-up to the review on #5954, where the same observation was made.
Test plan
rulesjob intestsworkflow detectsdotnet: truewhen this PR's diff is evaluated against the filter (verifiable in the PR's own CI — the filter change itself touches.github/workflows/tests.yaml, which triggersmain, sotest-dotnetshould run here regardless; the real verification is the next dotnet-only PR.)🤖 Generated with Claude Code