[feature] Add skipped inventory aggregates for issue 267#279
Merged
paul-fresquet merged 10 commits intomasterfrom Feb 18, 2026
Merged
[feature] Add skipped inventory aggregates for issue 267#279paul-fresquet merged 10 commits intomasterfrom
paul-fresquet merged 10 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements persisted skip aggregates for inventory tracking (issue #267) to enable cross-machine reporting of skipped entries. The changes add both persistent storage of skip counts in InventoryPart and runtime tracking in InventoryProcessData, preparing the foundation for UI display (issue #268).
Changes:
- Added
SkippedCountsByReasondictionary and related methods toInventoryPartfor persistent skip count storage - Extended
InventoryProcessDatawith thread-safe runtime skip counters and per-reason tracking - Updated
InventoryBuilder.RecordSkippedEntryto write skip data to both persistent and runtime storage in a single code path
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ByteSync.Client/Models/Inventories/InventoryPart.cs | Added persisted skip aggregates: SkippedCountsByReason dictionary, SkippedCount property, GetSkippedCountByReason() and RecordSkippedEntry() methods |
| src/ByteSync.Client/Business/Inventories/InventoryProcessData.cs | Added runtime skip tracking with thread-safe counters (_skippedCount, _skippedCountsByReason) and reset handling in ClearSkippedEntries() |
| src/ByteSync.Client/Services/Inventories/InventoryBuilder.cs | Updated to write skip data through both InventoryPart and InventoryProcessData in single call |
| tests/ByteSync.Client.UnitTests/Models/Inventories/InventoryPartSkippedCountsTests.cs | New test class covering aggregate behavior and null handling for InventoryPart skip tracking |
| tests/ByteSync.Client.UnitTests/Business/Inventories/InventoryProcessDataTests.cs | Added tests for runtime skip counter updates and reset behavior |
| tests/ByteSync.Client.UnitTests/Services/Inventories/InventoryBuilderInspectorTests.cs | Extended existing tests to verify skip counts are propagated to both runtime and persistent storage |
| tests/ByteSync.Client.UnitTests/Services/Inventories/InventoryLoaderIncompleteFlagTests.cs | Added test verifying skip counts persist through serialization/deserialization |
| AGENTS.md | Refined language about when agents can create branches (unrelated to PR purpose) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary:
Key changes:
InventoryPart(SkippedCountsByReason,SkippedCount,GetSkippedCountByReason,RecordSkippedEntry).InventoryProcessDatawith runtime aggregate counters (SkippedCount+ per-reason counts) and reset handling.InventoryBuilder.RecordSkippedEntryto write through a single path:InventoryPartaggregate + runtime skipped entry/counters.Notes/risks:
Closes #267