fix: add path traversal validation to datapoints endpoints#2610
Open
q1uf3ng wants to merge 1 commit intoPAIR-code:mainfrom
Open
fix: add path traversal validation to datapoints endpoints#2610q1uf3ng wants to merge 1 commit intoPAIR-code:mainfrom
q1uf3ng wants to merge 1 commit intoPAIR-code:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have already signed the Google CLA. Please recheck. |
User-supplied paths in _save_datapoints and _load_datapoints are passed directly to file I/O without validation. An attacker can use path traversal sequences to read or write arbitrary files on the server. Add _validate_data_path() that resolves the path and ensures it stays within the configured data_dir.
94a7ffd to
cd09e6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_save_datapointsand_load_datapointsinapp.pypass user-supplied file paths directly toopen()without validation. A path like../../etc/passwdreads or writes arbitrary files on the server.Fix
Add
_validate_data_path()that resolves paths withos.path.realpath()and rejects anything outside the configureddata_dir.Reproduction