Add PersonSkeleton common type and skeleton field for Occupant#899
Open
Add PersonSkeleton common type and skeleton field for Occupant#899
Conversation
Contributor
|
Would it not be easier to just re-use either PersonAttributes or PersonAttributes::Bone directly for now? This should be possible, as we have done so in the past. Maybe cannot be done in osi_common (potential circular includes, I would imagine), but directly in osi_occupant this should be possible... |
Add Occupant.Skeleton message in osi_occupant.proto that reuses MovingObject.PedestrianAttributes.Bone for occupant pose representation. The skeleton root is anchored via bbcenter_to_root relative to the vehicle bounding box center. Add migration notes on PedestrianAttributes documenting the plan to introduce a common skeleton type in OSI 4. Add .github/copilot-instructions.md for Copilot context. Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
3e38540 to
1e2335f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Extends the Occupant message to support skeleton/posture data for vehicle occupants (e.g. for driver monitoring / DCAS use cases).
Add a description
What is this change?
Adds an \Occupant.Skeleton\ message in \osi_occupant.proto\ that reuses \MovingObject.PedestrianAttributes.Bone\ directly, giving occupants a skeleton representation analogous to what pedestrians already have.
Changes:
epeated MovingObject.PedestrianAttributes.Bone skeleton_bone. New import of \osi_object.proto.
Does it break any existing functionality?
No. All changes are purely additive. Zero type duplication — \PedestrianAttributes.Bone\ is referenced directly.
How has it been tested?
Checklist