tls-openssl.c: Handle errors in read/write operations#1506
Merged
zdohnal merged 1 commit intoOpenPrinting:masterfrom Mar 5, 2026
Merged
tls-openssl.c: Handle errors in read/write operations#1506zdohnal merged 1 commit intoOpenPrinting:masterfrom
zdohnal merged 1 commit intoOpenPrinting:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Openssl functions return values <= 0, so we have to handle them separately to process the errors later together in the same code segment.
zdohnal
force-pushed
the
openssl-write-error-handle
branch
from
8851b0b to
66db189
Compare
michaelrsweet
approved these changes
Mar 4, 2026
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
Looks reasonable enough, would be nice to get more detailed errors but at this level we really don't have a way to bubble those up...
Member
Author
|
@michaelrsweet thx! I focused here on the fact which errors are recoverable and which not for now - the only relevant ones looked the WANT_READ/WANT_WRITE errors, because the other was happening only when Once I merge this, I will add some comments into the functions to make it clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Openssl functions return values <= 0, so we have to handle them separately to process the errors later together in the same code segment.