Skip to content

fix(115_open): refresh OSS STS token during multipart upload #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CloudCauldron wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(115_open): refresh OSS STS token during multipart upload #2575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions drivers/115_open/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,30 @@ func (d *Open115) multpartUpload(ctx context.Context, stream model.FileStreamer,
return err
}

// The OSS STS token returned by UploadGetToken expires in about 1 hour.
// A slow or large upload can outlive it, causing SecurityTokenExpired /
// InvalidAccessKeyId. Refresh the token ahead of expiry and rebuild the OSS
// client with the new credentials, reusing the same multipart session (imur)
// to keep uploading the remaining parts.
tokenObtained := time.Now()
refreshOSSToken := func() error {
newToken, err := d.client.UploadGetToken(ctx)
if err != nil {
return err
}
newClient, err := netutil.NewOSSClient(newToken.Endpoint, newToken.AccessKeyId, newToken.AccessKeySecret, oss.SecurityToken(newToken.SecurityToken))
if err != nil {
return err
}
newBucket, err := newClient.Bucket(initResp.Bucket)
if err != nil {
return err
}
bucket = newBucket
tokenObtained = time.Now()
return nil
}

fileSize := stream.GetSize()
chunkSize := calPartSize(fileSize)
ss, err := streamPkg.NewStreamSectionReader(stream, int(chunkSize), &up)
Expand All @@ -100,6 +124,13 @@ func (d *Open115) multpartUpload(ctx context.Context, stream model.FileStreamer,
return ctx.Err()
}

// The token lives ~1 hour; refresh after 45 minutes to keep a safe margin.
if time.Since(tokenObtained) > 45*time.Minute {
if err := refreshOSSToken(); err != nil {
return err
}
}

partSize := chunkSize
if i == partNum {
partSize = fileSize - (i-1)*chunkSize
Expand Down