fix(net): honor proxy settings when uploading to 115/115 Open/PikPak OSS#2222
Open
fix(net): honor proxy settings when uploading to 115/115 Open/PikPak OSS#2222
Conversation
Co-authored-by: jyxjjj <16695261+jyxjjj@users.noreply.github.com>
Co-authored-by: jyxjjj <16695261+jyxjjj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [BUG] Fix HTTPS proxy support for PikPak driver uploads
Honor HTTPS proxy settings for 115/115 Open/PikPak OSS uploads
Mar 13, 2026
jyxjjj
reviewed
Mar 13, 2026
jyxjjj
reviewed
Mar 13, 2026
jyxjjj
approved these changes
Mar 13, 2026
xrgzs
approved these changes
Mar 13, 2026
Member
xrgzs
left a comment
There was a problem hiding this comment.
Running tool: /opt/homebrew/bin/go test -test.fullpath=true -timeout 30s -run ^TestNewOSSClientUsesEnvironmentHTTPSProxy$ github.com/OpenListTeam/OpenList/v4/internal/net
DEBU[2026-03-13T11:08:55.8745] Download start
=== RUN TestNewOSSClientUsesEnvironmentHTTPSProxy
--- PASS: TestNewOSSClientUsesEnvironmentHTTPSProxy (0.00s)
PASS
ok github.com/OpenListTeam/OpenList/v4/internal/net 1.518s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
115, 115 Open, and PikPak uploads were creating Aliyun OSS clients without the project’s proxy-aware HTTP transport, so upload traffic bypassed
HTTPS_PROXYeven though other request paths already respected environment proxy settings. This change routes those OSS upload requests through the same proxy configuration used elsewhere.Proxy-aware OSS client construction
internal/net.NewOSSClient(...)helper that wrapsoss.New(...)with the project’s HTTP client configuration.http.ProxyFromEnvironmentplus configured proxy override) instead of adding driver-specific proxy logic.Apply to affected upload paths
drivers/115drivers/115_opendrivers/pikpakFocused coverage
HTTPS_PROXY.Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.