Skip to content

Eliminate O(n^2) status removal in DashboardTreeTableModel #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicoPiel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Eliminate O(n^2) status removal in DashboardTreeTableModel #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/src/com/mirth/connect/client/ui/DashboardTreeTableModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,13 +498,14 @@ private void updateChannelNodes(List<DashboardStatus> statuses, MutableTreeTable
}

private void updateChannelNodes(Map<String, DashboardStatus> statusMap, List<DashboardStatus> statuses, MutableTreeTableNode parent) {
Set<DashboardStatus> matched = new HashSet<>();
for (int i = 0; i < parent.getChildCount(); i++) {
AbstractDashboardTableNode node = (AbstractDashboardTableNode) parent.getChildAt(i);

if (statusMap.containsKey(node.getDashboardStatus().getKey())) {
// Remove channels that do exist from the list of statuses so they will not be added again later.
DashboardStatus status = statusMap.get(node.getDashboardStatus().getKey());
statuses.remove(status);
matched.add(status);
// Update the channel status
node.setDashboardStatus(status);
modelSupport.firePathChanged(new TreePath(getPathToRoot(node)));
Expand All @@ -513,6 +514,7 @@ private void updateChannelNodes(Map<String, DashboardStatus> statusMap, List<Das
updateConnector(statusMap, node);
}
}
statuses.removeAll(matched);
}

private void removeLingeringChannelNodes(List<DashboardStatus> statuses, MutableTreeTableNode root) {
Expand Down
Loading