Fix and enable the AlternateRootDN ACI test#706
Merged
vharseko merged 1 commit intoJul 8, 2026
Merged
Conversation
The test class name never matched the failsafe include patterns, so it has not run since the Maven migration, and it rotted against two changes in the proxied authorization ACI semantics: - the targetcontrol ACI for the proxied authorization control is evaluated against the entry of the authenticated user, not against the search target, so it must be placed on that entry; - the proxy right is evaluated against the entry being authorized as - here the root DN entries under cn=config - so it must be granted through a global ACI targeting cn=Root DNs,cn=config. Also fix a copy-paste error (the third search proxied as the admin alternate DN instead of the root one) and rename the class to AlternateRootDNTestCase so that the failsafe include patterns pick it up (2/2 green, ~14s).
vharseko
added
tests
maximthomas
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AlternateRootDN(a Sun-era test of ACI behaviour for alternate root bind DNs, including proxied authorization as alternate root DNs) has never run since the Maven migration: its class name does not match any failsafe include pattern (Test*,*Test,*Tests,*TestCase,*TestCases). Once forced to run,testAlternateProxyDNsfailed — the test rotted against two changes in the proxied authorization ACI semantics:evaluateProxyAuthControls()evaluates ACIs against the entry of the authenticated user (isAllowed(authDN, ...)), not against the search target. The test placed the control ACI on the search target entry →Unavailable Critical Extension. It now lives on the authenticating user's entry.AciHandler.mayProxy()evaluatesallow (proxy)against the entry being authorized as — here the root DN entries undercn=config, which only global ACIs can reach. A global ACI targetingcn=Root DNs,cn=configis added → previouslyAuthorization Denied.Also fixes a copy-paste error (the third search proxied as the admin alternate DN instead of the root one) and renames the class to
AlternateRootDNTestCaseso the failsafe include patterns pick it up.Verification
Two consecutive runs: 2/2 green, ~14s each.
Found during the
slowgroup audit follow-up (#684-#705).