Run OpenFM unit tests and fix NotCondition.equals reflexivity

[vharseko]

OpenFM has carried a blanket <skipTests>true</skipTests> since 2bbaf3849b (2013), hiding all 178 of its tests. mvn test on the module now runs 48 tests, all green.

Why the flag was there

The OpenSSO-era tests obtain an Application SSO token via AdminTokenAction and drive ServiceManager/IdRepo directly. Outside a configured server they fail in the constructor or @BeforeClass, and TestNG aborts the entire suite when one class cannot be instantiated — so a single server-dependent test hid all the others. CreateSoapSTSDeploymentTest documented this in a comment.

This replaces the blanket flag with an explicit surefire exclude list for the 53 server-dependent classes. excludes rather than includes is deliberate: a newly added test is still picked up by the default patterns, instead of silently not running — the trap that created this situation.

A real defect in openam-core

Once running, NotConditionTest caught exactly what it was written for in 2014. LogicalCondition.equals read this.eConditions directly but called object.getEConditions(). NotCondition overrides that getter and keeps its condition in a separate field, which is always null in the parent — so the comparison always failed:

NotCondition.equals(self) = false      ->  true
List.contains(n)          = false      ->  true
List.remove(n)            = false      ->  true

This violates the reflexivity contract of Object.equals. HashSet happened to work only because it compares references first. AndCondition/OrCondition are unaffected — they do not override the getter. Present since 2012, invisible because the test never ran.

Test-side fixes

• Restored six fixtures left behind in the OpenSSO tree during the Maven migration (resourceNameIndex*, resourceNameSplit*, eUnitTest.data).
• ResourceNameSplitTest declared @Test public boolean testHost(); TestNG silently ignores non-void methods — a leftover from the OpenSSO harness where true meant pass. Made them void.
• resourceNameSplitHost.properties expected scheme-carrying host indexes (http://www.sun.com), but every implementation in history emits scheme-agnostic ://www.sun.com. The fixture was stale before it was ever run; updated to the real contract.
• CreateSoapSTSDeploymentTest: supply the retry params added in OPENAM-8772 (2016).
• ConfigureSocialAuthNTest: the crypto value was intentionally removed in OPENAM-5851 (2015) — the same commit documented "If client_secret entered, entry is ignored". The product is right here; the test expectation was stale.

Verification

Module	Tests
OpenFM (mvn test, no flags)	48 ✅ (was 0)
openam-core	1797 ✅
openam-entitlements	564 ✅
openam-federation-library	43 ✅

Not in scope

The 53 excluded classes were designed to run inside a deployed OpenAM: TestHarness.execute(HttpServletResponse, String) was invoked by a servlet in the webapp and ran TestNG in-container. That servlet no longer exists — TestHarness is an orphan with no caller. Reviving them needs a new harness (rebuild the in-container entry point, rewrite as black-box REST/Selenium, or bootstrap the server stack in-JVM) and is a separate project. The exclude list is the inventory to work from.