Skip to content

tests: deploy tests#1280

Merged
josephjclark merged 20 commits intomainfrom
1270-cli-unit-tests-for-deploy
Mar 6, 2026
Merged

tests: deploy tests#1280
josephjclark merged 20 commits intomainfrom
1270-cli-unit-tests-for-deploy

Conversation

@doc-han
Copy link
Collaborator

@doc-han doc-han commented Feb 26, 2026

Short Description

Adds integration tests for deploy/pull v1 & v2

Fixes #1270

Implementation Details

A more detailed breakdown of the changes, including motivations (if not provided in the issue).

QA Notes

List any considerations/cases/advice for testing/QA here.

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Release branch checklist

Delete this section if this is not a release PR.

If this IS a release branch:

  • Run pnpm changeset version from root to bump versions
  • Run pnpm install
  • Commit the new version numbers
  • Run pnpm changeset tag to generate tags
  • Push tags git push --tags

Tags may need updating if commits come in after the tags are first generated.

@doc-han doc-han linked an issue Feb 26, 2026 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this to New Issues in Core Feb 26, 2026
@doc-han
Copy link
Collaborator Author

doc-han commented Mar 2, 2026

@josephjclark so the failing test here is the weird case. actually doesn't work as expected for me

@doc-han doc-han marked this pull request as ready for review March 2, 2026 09:16
@josephjclark
Copy link
Collaborator

Pushing some changes here:

  1. I've added some assertions and made some small refactors to the v1 deploy
  2. I've hit some really big problems with the test commands loading bad values from my environment. So I've added fixes around that.
  3. I've restructured v1 pull tests a it - I basically want to test pull standalone. We used to have an older test on that but I've ripped it out. One test is still failing but I'll get to it tomorrow

@josephjclark
Copy link
Collaborator

josephjclark commented Mar 4, 2026

I'm sure there's a bug in v1 where state files get written with workflow ids that aren't lower cased.

I keep seeing issues where my-workflow is written to state.json as My-Workflow, and that keeps causing tests to break.

I don't want to get involved in v1 code so I'm leaving this for now. I'll raise an issue if I can find a clear repro case.

EDIT: fixing the casing in the yaml files help this. I think tests were accidentally passing before because they were pointing to state files that didn't exist (a different bug which I've fixed)

Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the tests (and I've fixed the issues) but I can't merge this until the lightning mock API has been updated to not duplicate the version algorithm.

I expect I'll fix this on Friday

@github-project-automation github-project-automation bot moved this from New Issues to In review in Core Mar 4, 2026
@doc-han
Copy link
Collaborator Author

doc-han commented Mar 4, 2026

Resolved. lightning mock now uses the same hashing as the projects package

@doc-han doc-han requested a review from josephjclark March 4, 2026 22:40
@josephjclark
Copy link
Collaborator

Oh thank you @doc-han , that's super helpful!

*
* I suspect the fail here is catching a real bug
*/
test.serial.skip(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this skipped because I think it's a real bug. I'm investigating that on another branch - but I want to merge the good stuff here into main

@josephjclark josephjclark merged commit 84f4066 into main Mar 6, 2026
1 of 2 checks passed
@josephjclark josephjclark deleted the 1270-cli-unit-tests-for-deploy branch March 6, 2026 10:22
@github-project-automation github-project-automation bot moved this from In review to Done in Core Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

CLI: Unit tests for deploy

2 participants