Conversation
|
@josephjclark so the failing test here is the weird case. actually doesn't work as expected for me |
One test still failing
|
Pushing some changes here:
|
|
I'm sure there's a bug in v1 where state files get written with workflow ids that aren't lower cased. I keep seeing issues where I don't want to get involved in v1 code so I'm leaving this for now. I'll raise an issue if I can find a clear repro case. EDIT: fixing the casing in the yaml files help this. I think tests were accidentally passing before because they were pointing to state files that didn't exist (a different bug which I've fixed) |
Casing in the yaml files was causing issues
josephjclark
left a comment
There was a problem hiding this comment.
Love the tests (and I've fixed the issues) but I can't merge this until the lightning mock API has been updated to not duplicate the version algorithm.
I expect I'll fix this on Friday
|
Resolved. lightning mock now uses the same hashing as the projects package |
|
Oh thank you @doc-han , that's super helpful! |
| * | ||
| * I suspect the fail here is catching a real bug | ||
| */ | ||
| test.serial.skip( |
There was a problem hiding this comment.
Leaving this skipped because I think it's a real bug. I'm investigating that on another branch - but I want to merge the good stuff here into main
Short Description
Adds integration tests for deploy/pull v1 & v2
Fixes #1270
Implementation Details
A more detailed breakdown of the changes, including motivations (if not provided in the issue).
QA Notes
List any considerations/cases/advice for testing/QA here.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.